Add Span and Tracer macro implementations
#56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
force-pushed
the
tracing-api-macro
branch
from
5c535b2 to
12d9c92
Compare
iRevive
force-pushed
the
tracing-api-macro
branch
from
12d9c92 to
a379a80
Compare
iRevive
force-pushed
the
tracing-api-macro
branch
from
a379a80 to
5c622d6
Compare
|
@rossabaker could you take a look once you have time, please? |
|
After #37, is there anything here that's unique, or is this just a strict subset of that? |
|
It's a subset of #37. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to split #37 into smaller pieces to simplify the review process.
Notables changes:
SpanMacroandTracerMacro)Span#setAttribute->Span#addAttributeSpan#createAuto->Span#startSpan#startManual->Span#startUnmanaged