-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update opentelemetry-semconv
to 1.24.0-alpha
#568
Conversation
9b3df59
to
deb38ee
Compare
deb38ee
to
3118ac5
Compare
.settings(munitDependencies) | ||
.settings(scalafixSettings) | ||
|
||
lazy val `semconv-experimental` = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing depends on the otel4s-semconv-experimental
. I would expect users to pull this dependency directly into their projects.
@@ -94,13 +93,29 @@ sealed trait TelemetryResource { | |||
} | |||
|
|||
object TelemetryResource { | |||
private[otel4s] object ResourceAttributes { | |||
val TelemetrySdkName: AttributeKey[String] = | |||
AttributeKey("telemetry.sdk.name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we shouldn't depend on the experimental artifacts, the values are hardcoded instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my main concern with this is that it will quietly change and we won't remember to keep up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the strategy correctly, the promotion to the 'stable' convention should be the following:
- keys under
TelemetryExperimentalAttributes
will be deprecated TelemetryAttributes
will be generated under the stable module
Hopefully, we will notice this and update the hardcoded attributes accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hugely in favour of this making the next release
@@ -94,13 +93,29 @@ sealed trait TelemetryResource { | |||
} | |||
|
|||
object TelemetryResource { | |||
private[otel4s] object ResourceAttributes { | |||
val TelemetrySdkName: AttributeKey[String] = | |||
AttributeKey("telemetry.sdk.name") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my main concern with this is that it will quietly change and we won't remember to keep up
There are several major breaking changes:
semconv-experimental
ResourceAttributes
andSemanticAttributes
. Now,http.request.header
attribute lives in theHttpAttributes
object.org.typelevel.otel4s.semconv.trace
toorg.typelevel.otel4s.semconv
The changes are based on the https://github.com/open-telemetry/semantic-conventions-java/releases/tag/v1.24.0.