Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core-metrics: add varargs apply to the BucketBoundaries #714

Merged
merged 1 commit into from
Jul 27, 2024
Merged

core-metrics: add varargs apply to the BucketBoundaries #714

merged 1 commit into from
Jul 27, 2024

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Jul 24, 2024

A quality of life improvement.

@iRevive iRevive added the metrics Improvement to metrics module label Jul 24, 2024
NthPortal
NthPortal approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@NthPortal NthPortal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry it took me so long to get to this—have been sick

@iRevive iRevive merged commit 543dda8 into typelevel:main Jul 27, 2024
10 checks passed
@iRevive iRevive deleted the core-metrics/bucket-boundaries-var-args-apply branch July 27, 2024 07:06
@iRevive
Copy link
Contributor Author

iRevive commented Jul 27, 2024

sorry it took me so long to get to this—have been sick

Oh, I hope you feel better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NthPortal NthPortal NthPortal approved these changes

@rossabaker rossabaker Awaiting requested review from rossabaker

Assignees
No one assigned
Labels
metrics Improvement to metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iRevive @NthPortal