Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make printing of Commands failures more readable #634

Merged

Conversation

jonaskoelker
Copy link
Contributor

@jonaskoelker jonaskoelker commented Mar 1, 2020

Example output:

[info] > Labels of failing property:
[info] Initial State:
[info]   0
[info] Sequential Commands:
[info]    1. TakeNumber => 1
[info]    2. TakeNumber => 2
[info]    3. TakeNumber => 3
[info] Parallel Commands (starting in state = 3)
[info]    1. TakeNumber => 4
[info]    2. TakeNumber => 5
[info]    3. TakeNumber => 7
[info]
[info]    1. TakeNumber => 6
[info]    2. TakeNumber => 7
[info] ARG_0: ...
[info] ARG_0_ORIGINAL: ...

(Here "..." is an abberivation.)

Example output:

[info] > Labels of failing property:
[info] Initial State:
[info]   0
[info] Sequential Commands:
[info]    1. TakeNumber => 1
[info]    2. TakeNumber => 2
[info]    3. TakeNumber => 3
[info] Parallel Commands (starting in state = 3)
[info]    1. TakeNumber => 4
[info]    2. TakeNumber => 5
[info]    3. TakeNumber => 7
[info]
[info]    1. TakeNumber => 6
[info]    2. TakeNumber => 7
[info] ARG_0: ...
[info] ARG_0_ORIGINAL: ...

(Here "..." is an abberivation.)
@SethTisue
Copy link
Member

I'm wondering if we should just merge this, even though nobody has stepped forward with a close review. The changes only affect printing, so that doesn't seem high risk.

@jonaskoelker is it worth considering adding test coverage for this...?

@ashawley
Copy link
Contributor

Yes, I think this is a low risk change, as well. Tests would be a good idea, but adding tests for outputs is difficult the way the Commands API is currently written.

@ashawley ashawley merged commit 281d93c into typelevel:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants