Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onwards and upwards #879

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

armanbilge
Copy link
Member

Bumps Scala 3 to 3.1.x and Scalacheck to 1.16.x. Closes #878. Supersedes #868.

@adampauls
Copy link

I'm dying of curiosity: what is stopping this PR from being merged? Lots of upstream stuff seems to be blocked on it?

@armanbilge
Copy link
Member Author

@adampauls see the extensive discussion in typelevel/cats#4016. So, historically it's been a controversial issue, although it may not be as much anymore.

FWIW my mind has been stuck on this PR too :) any @typelevel/scalacheck maintainer feel inclined to merge, or at least add another approval?

@SethTisue
Copy link
Member

I've asked on #878 for some input from the Center and/or Virtus

@SethTisue SethTisue merged commit 0ac8005 into typelevel:main Mar 29, 2022
@julienrf
Copy link

Please note that Scala 3.1.2 will support -scala-output-version. Would you consider using this feature to emit Scala 3.0-compatible TASTy files?

@armanbilge
Copy link
Member Author

What is the story with -scala-output-version and Scala Native, which doesn't support Scala 3.0? Do we have to special case our builds?

-scala-output-version is extremely important, and for sure we should use it to emit 3.1-compatible TASTy from 3.2+ which is just around the corner. But pinning to 3.0 just doesn't seem worth it IMHO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Scala 3.0, publish for 3.1?
5 participants