Relax type equality constraint to subtype #53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring type equality for syntax methods when there's a constraint on the instance type causes problems if the target type needs to be inferred (see this issue in Cats for some discussion).
Relaxing the constraint to only require evidence of a subtype relationship helps type inference and (as far as I can tell) doesn't cause other problems.
I've also tested this change against 0.6.1 and it looks like it could be backported for a 0.6.2 release (which would help us out with Cats 0.4.0).
/cc @ceedubs @mpilquist