-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations #570
base: master
Are you sure you want to change the base?
Type annotations #570
Conversation
# Conflicts: # drawBot/context/baseContext.py # drawBot/context/tools/imageObject.py # drawBot/drawBotDrawingTools.py # requirements.txt
🙌 super!! thanks |
thank you for all the support and guidance |
this looks good to me! sphinx doc building is also adjusted and improved |
How is it going with the review process? @typemytype @justvanrossum |
Apologies! I will continue soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started to do a new review, and left some comments. But then I came across my earlier feedback which seems to have not been addressed at all, so I'll stop here.
I'll go through them on Monday! |
Hey @justvanrossum! @typemytype and I fixed the issues you highlighted. You can proceed with the review 🤓 |
@justvanrossum I would like to finish this PR :) |
I can imagine! :) There's still a bunch of unresolved feedback, though. (And some feedback that has been resolved, but not marked as resolved.) |
I think I resolved all the issues. There are commit links too. Am I missing something? |
Just go to “show hidden” and within that one more time. |
To be honest, looking to outdated hidden message is a bit confusing... but hurray found them deep inside the comment stream! |
@justvanrossum I should have answered to all the issues. Please, if there's something missing tag me directly, as the PR interface is getting a bit confusing, thanks! |
Hey! Can I do anything to move the ball forward? |
The aim of this pull request is to add type annotations to the
drawBot
public interface. Here are the main things @typemytype and I worked on:drawBot.__init__.py
file is partially generated to expose the instance methods outside, allowingfrom drawBot import whatever
and benefiting from the annotations in the code editorAdditionally, we made some other minor fixes:
drawBot
test scripts (type annotations benefit)Some tests are failing on my OS (Sonoma 14.4.1). Looking at the
difference.pdf
, it mostly seems to be related to hinting, hyphenation, text baseline shift, and blending of colors. Depending on the OS GitHub will use to run the tests, the tests might keep failing or not.We still need to generate automatically basic tests for the
ImageObject
class. We plan to work on it next week.