fix: support DeleteResult in SQLiteDriver (#8237)

typeorm · Oct 2, 2021 · b678807 · b678807
1 parent d7d19e9
commit b678807
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/src/driver/sqlite/SqliteQueryRunner.ts b/src/driver/sqlite/SqliteQueryRunner.ts
@@ -51,13 +51,15 @@ export class SqliteQueryRunner extends AbstractSqliteQueryRunner {
             const databaseConnection = await this.connect();
             this.driver.connection.logger.logQuery(query, parameters, this);
             const queryStartTime = +new Date();
-            const isInsertQuery = query.substr(0, 11) === "INSERT INTO";
+            const isInsertQuery = query.startsWith("INSERT ");
+            const isDeleteQuery = query.startsWith("DELETE ");
+            const isUpdateQuery = query.startsWith("UPDATE ");
 
             const execute = async () => {
-                if (isInsertQuery) {
-                    databaseConnection.run(query, parameters, handler);
+                if (isInsertQuery || isDeleteQuery || isUpdateQuery) {
+                    await databaseConnection.run(query, parameters, handler);
                 } else {
-                    databaseConnection.all(query, parameters, handler);
+                    await databaseConnection.all(query, parameters, handler);
                 }
             };
 

diff --git a/test/functional/query-builder/delete/query-builder-delete.ts b/test/functional/query-builder/delete/query-builder-delete.ts
@@ -95,9 +95,8 @@ describe("query builder > delete", () => {
 
     it("should return correct delete result", () => Promise.all(connections.map(async connection => {
 
-        // don't run test for sqlite and sqljs as they don't return affected rows
-        // better-sqlite3 works correctly
-        if (connection.name === "sqlite" || connection.name === "sqljs" || connection.name === "sap")
+        // don't run test for SAP Hana as it won't return these
+        if (connection.name === "sap")
             return;
 
         // save some users