fix: using async datasource to configure typeorm

[nover]

Fixes #10168

Description of change

The check in CommandUtils.ts for detecting whether the DataSource-source is a promise is broken.

Rather than testing whether it's a promise, simply await the value and use it. The await operator is defined in such way that if the thing is not awaitable we simply get the value back

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/await#return_value

Pull-Request Checklist

• Code is up-to-date with the master branch
• npm run format to apply prettier formatting
• npm run test passes with this change
• This pull request links relevant issues as Fixes #0000
• There are new or updated unit tests validating the change - no because all relevant unit tests have been disabled by the code-owners
• Documentation has been updated to reflect this change
• The new commits follow conventions explained in CONTRIBUTING.md

[hinogi]

I think another way would be to check if .then is available

[nover]

I think another way would be to check if .then is available

We could do that explicitly and only await if the object is "thenable" - but this is exactly what await does under the hood (from MDN):

Await result 

The fulfillment value of the promise or thenable object, or, 
if the expression is not thenable, the expression's own value.

[hinogi]

I think another way would be to check if .then is available

We could do that explicitly and only await if the object is "thenable" - but this is exactly what await does under the hood (from MDN):

Await result 

The fulfillment value of the promise or thenable object, or, 
if the expression is not thenable, the expression's own value.

Then you are absolutely right. 👍

[nover]

Any chance of getting this merged soon @hinogi ?

[hinogi]

@nover I am not a maintainer, I am just helping with reviewing as much as I can to accelerate the process a bit.

[pleerock]

thanks @nover @hinogi !