-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AndroidEmulatorRunnerV2 #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution
We have typings though to make things more type safe and right now they have to be deduced manually and put into wrapperstogenerate
...src/gen/kotlin/it/krzeminski/githubactions/actions/reactivecircus/AndroidEmulatorRunnerV2.kt
Show resolved
Hide resolved
...src/gen/kotlin/it/krzeminski/githubactions/actions/reactivecircus/AndroidEmulatorRunnerV2.kt
Show resolved
Hide resolved
...src/gen/kotlin/it/krzeminski/githubactions/actions/reactivecircus/AndroidEmulatorRunnerV2.kt
Outdated
Show resolved
Hide resolved
...src/gen/kotlin/it/krzeminski/githubactions/actions/reactivecircus/AndroidEmulatorRunnerV2.kt
Outdated
Show resolved
Hide resolved
...src/gen/kotlin/it/krzeminski/githubactions/actions/reactivecircus/AndroidEmulatorRunnerV2.kt
Outdated
Show resolved
Hide resolved
...generator/src/main/kotlin/it/krzeminski/githubactions/wrappergenerator/WrappersToGenerate.kt
Outdated
Show resolved
Hide resolved
@LeoColman unless you can ask the action owner to provide the typings by onboarding https://github.com/krzema12/github-actions-typing :) Then this PR would be literally a one-liner + generated code. It would be actually the preferred path forward, and if it fails/takes long, we can fall back to placing the typings here as you did. |
…wrappergenerator/WrappersToGenerate.kt Co-authored-by: Piotr Krzemiński <3110813+krzema12@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a failed build - ktlint complains, could you fix the style?
Also let me ensure that you've seen my recommendation to ask the owner to provide the typings in the action itself. I've documented it in the contribution guidelines: https://github.com/krzema12/github-actions-kotlin-dsl/blob/19783861f4ba2eddc28fc2f2085ba1f7ca3e7b45/CONTRIBUTING.md?plain=1#L18 this is non-blocking for this PR, but would be good to do it simultaneously 😄
Ah, I thought it was more of an OR xD |
Complementary PR: |
Also, I've fixed the KTlint requirement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@LeoColman thanks for this! I'll take care of merging. |
Merging in #357. |
No description provided.