Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Travis configuration #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve Travis configuration #35

wants to merge 1 commit into from

Conversation

markusjura
Copy link
Contributor

  • Execute tests both on Scala 2.11 and 2.12
  • Use Scala 2.12.4 instead of 2.12.3

@markusjura
Improve Travis configuration
f7e4b3c 
- Execute tests both on Scala 2.11 and 2.12
- Use Scala 2.12.4 instead of 2.12.3
@markusjura
Copy link
Contributor Author

@longshorej Can do a quick review please.

I am also happy if you add me as a contributor to this project. I'll then try to maintain the project as best as I can.

longshorej
longshorej reviewed Nov 9, 2017
View reviewed changes
.travis.yml
@@ -3,7 +3,7 @@ sudo: required
language: scala

scala:
- 2.12.3
- 2.12.4
- 2.11.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're using sbt +test below, there isn't a need to declare versions to Travis. I'd just remove this scala section and simply let SBT take care of testing across versions.

@longshorej
Copy link
Contributor

Sent an invite, thanks for offering! Hope things are going well at MOIA.

@markusjura
Copy link
Contributor Author

Accepted. Yes, going very well. And at Lightbend?

@amarouni
Copy link
Contributor

@longshorej @markusjura Any update guys ? I can take a look also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longshorej longshorej longshorej left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markusjura @longshorej @amarouni