Add converter for typedef property

[hyperupcall]

Hoi! ^w^ 👋

PR Checklist

• Fixes Missing Converter for typedef #937
• That issue was marked as status: accepting prs

Overview

The typedef property of TSLint is now considered during the conversion. All config options except call-signature and arrow-call-signature are accounted for. Options unaccounted for are mentioned in the notices array, when applicable

The linked issue and the ESLint typedef docs mentions that explicit-function-return-type and explicit-module-boundary-types should be used when converting call-signature and arrow-call-signature. I did that in a separate branch here, but I wasn't 100% confident that my conversion was correct, so I left it out for now. If it is close to what is considered acceptable, maybe I can add it to this PR?

I'll also add that I had to install @swc/core to get things to run, despite this mentioning its not required - not sure what's up with that. Also the Docs say Node 12 works, but 14 was the minimum LTS that worked for me (Jest threw SyntaxError: Unexpected token '.' when it encountered optional chaining)

[JoshuaKGoldberg]

Awesome, looks good so far. Glad to see this rule finally getting taken care of! 👏

Tests are failing (ci link) because a lack of coverage on lines 11,15,19,27,31. You'll want to add >=1 test case that covers them.

[JoshuaKGoldberg]

install @swc/core to get things to run

Huh, sorry about that - I'll send a separate PR to add it in.

[JoshuaKGoldberg]

Node 12 works, but 14 was the minimum LTS that worked for me (Jest threw SyntaxError: Unexpected token '.' when it encountered optional chaining)

Nice, following up on that too: #1374

[hyperupcall]

Thank you for your feedback! 😃 I will push the improved coverage and address your replies by this Friday Sunday (I have some Exams in the meantime)!

[JoshuaKGoldberg]

Good luck on the exams! ❤️

[hyperupcall]

I've implemented the changes, including use of Set(), Object.entries(), and got back to 100% codecov 😄

Also, both explicit-function-return-type and explicit-module-boundary-types are now used in the conversion process. Since I'm not super familiar with TSLint, I manually tested each one to be 100% sure conversion was the same. When this conversion is done, I added a message to to notices since ESLint seems to only lint all functions (not classifying between arrow functions and non-arrow functions as TSLint does with arrow-call-signature and call-signature. I tried my best to make it succinct, lemmie know if you have any improvements

Thank you for your patience, and let me know if I missed anything or should make any other changes! ^w^

[JoshuaKGoldberg]

Super, thanks so much @hyperupcall! 🙌

[JoshuaKGoldberg]

This should be available in tslint-to-eslint-config@2.12.0.