Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add 'no-unnecessary-qualifier' rule #231

Merged
merged 12 commits into from
Feb 11, 2019

Conversation

uniqueiniquity
Copy link
Contributor

Add equivalent rule to TSLint's no-unnecessary-qualifier.
This rule requires semantic information.

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #231 into master will increase coverage by <.01%.
The diff coverage is 94.54%.

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   94.53%   94.53%   +<.01%     
==========================================
  Files          62       63       +1     
  Lines        2706     2761      +55     
  Branches      701      718      +17     
==========================================
+ Hits         2558     2610      +52     
  Misses         57       57              
- Partials       91       94       +3
Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 94.54% <94.54%> (ø)

@uniqueiniquity
Copy link
Contributor Author

Regarding the diff coverage for the function i added to util.js, it only runs when used with TS 2.5. Do we have a way of testing that?

@armano2
Copy link
Member

armano2 commented Feb 8, 2019

we are not supporting typescript 2.5

@uniqueiniquity
Copy link
Contributor Author

@armano2 Ok, I can take out the back-compat parts.

@bradzacher
Copy link
Member

Hey @uniqueiniquity, sorry for the pain, but we just merged a big PR to convert the plugin to typescript.
Please have a look through the source code and migrate your PR to typescript as well.
Let me know if you've got any questions!

@bradzacher bradzacher added BLOCKED: awaiting ts migration enhancement: new plugin rule New rule request for eslint-plugin and removed enhancement: new plugin rule New rule request for eslint-plugin labels Feb 11, 2019
@uniqueiniquity uniqueiniquity merged commit cc8f906 into typescript-eslint:master Feb 11, 2019
@uniqueiniquity uniqueiniquity deleted the noUnnecQual branch February 11, 2019 21:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants