Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [no-parameter-properties] fix broken link #5611

Merged
merged 2 commits into from
Sep 11, 2022

Conversation

Josh-Cena
Copy link
Member

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Sep 7, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5cb3731. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5cb3731
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/631e7086debf0c0008d080db
😎 Deploy Preview https://deploy-preview-5611--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #5611 (5ba2fab) into main (77d76e2) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 5ba2fab differs from pull request most recent head 5cb3731. Consider uploading reports for the commit 5cb3731 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5611      +/-   ##
==========================================
+ Coverage   93.80%   93.86%   +0.06%     
==========================================
  Files         292      292              
  Lines       10009    10129     +120     
  Branches     3010     3054      +44     
==========================================
+ Hits         9389     9508     +119     
- Misses        338      339       +1     
  Partials      282      282              
Flag Coverage Δ
unittest 93.86% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts 98.97% <0.00%> (+0.13%) ⬆️

@@ -8,7 +8,7 @@ description: 'Disallow the use of parameter properties in class constructors.'

:::danger Deprecated

This rule has been deprecated in favour of the equivalent, better named [`parameter-properties`](./parameter-properties) rule.
This rule has been deprecated in favour of the equivalent, better named [`parameter-properties`](./parameter-properties.md) rule.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already working on prod though. Why would we need to add the .md?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not really working correctly, this generates link /rules/no-parameter-properties/parameter-properties instead of /rules/parameter-properties

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, very spooky, I do repro the 404 now. But I swear I didn't before...

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 8, 2022
@Josh-Cena
Copy link
Member Author

Sorry—something's not working in me 😄 Let's see what the OP is actually about, then

@Josh-Cena
Copy link
Member Author

Resurrecting per #5603 (comment). @JoshuaKGoldberg Seems it doesn't work on all devices for some weird reason. Plus it's generally a better practice to use Markdown file references.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) September 11, 2022 23:34
@JoshuaKGoldberg JoshuaKGoldberg merged commit 3918e08 into typescript-eslint:main Sep 11, 2022
@Josh-Cena Josh-Cena deleted the fix-link branch September 12, 2022 00:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: fix link to parameter-properties from no-parameter-properties
3 participants