fix: allow number and boolean values in validation message "$value" tokens #1467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As reported in issues #921 and #1046, the
$value
token in validation message isn't replaced properly in some cases. It turns out that the$value
token is parsed as expected only when the provided value is of typestring
, which results in commonly used validators with non-string values such as@MinLength
,@Min
,@MaxLength
,@Max
ect. to leave the$value
token in the validation message without replacing it. This PR relaxes the runtime typecheck performed when constructing the validation message by allowing typesboolean
andnumber
(alongsidestring
) to act as$value
token replacements.Checklist
Update index.md
)develop
)npm run prettier:check
passesnpm run lint:check
passesFixes
references #1046, references #921