assertObjectHasAttribute deprecated #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #317 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 255 255
===========================================
Files 88 88
Lines 1676 1676
===========================================
Hits 1676 1676 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
danepowell
commented
Feb 7, 2023
| @@ -17,7 +17,7 @@ | |||
| }, | |||
| "require-dev": { | |||
| "php-coveralls/php-coveralls": "^2.0.0", | |||
| "phpunit/phpunit": "^9", | |||
| "phpunit/phpunit": "9.5.28", | |||
There was a problem hiding this comment.
This is temporary to keep mutation tests running while I work on this PR.
This was referenced Feb 7, 2023
Merged
|
I think this approach is valid, it just needs to be more targeted. See #320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit deprecated assertObjectHasAttribute, arguing that any test that relies on it is of dubious value: sebastianbergmann/phpunit#4601
I tend to agree, these tests feel a little pointless to me. They're basically testing that a Response class has certain properties on it, which can never not be true unless we intentionally change the class.
@typhonius are you okay with this general approach? We use this pattern in dozens, possibly hundreds of tests. I want to be sure before I go fixing them all.
Edit: Ugh. It looks like mutation tests may indeed fail if we don't explicitly test the return types.