Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct work with worktrees #114

Merged
merged 1 commit into from
Jun 13, 2017
Merged

Conversation

alexeyten
Copy link
Contributor

Worktree's .git file contains absolute path to repository.
path.join incorrectly concatenates /path/to/worktree
with /path/to/real/.git/worktrees/worktree to
/path/to/worktree/path/to/real/.git/worktrees/worktree
instead of simple /path/to/real/...

Using path.resolve instead of path.join resolves this problem
while relative paths of submodules still works correctly.

Worktree's `.git` file contains absolute path to repository.
`path.join` incorrectly concatenates `/path/to/worktree`
with `/path/to/real/.git/worktrees/worktree` to
`/path/to/worktree/path/to/real/.git/worktrees/worktree`
instead of simple `/path/to/real/...`

Using `path.resolve` instead of `path.join` resolves this problem
while relative paths of submodules still works correctly.
@typicode
Copy link
Owner

Thank you!

@typicode typicode merged commit 333ca98 into typicode:master Jun 13, 2017
@alexeyten alexeyten deleted the worktrees branch June 14, 2017 08:08
@alexeyten alexeyten mentioned this pull request Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants