Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix init not work on pnpm #1334 #1347

Merged
merged 7 commits into from
Jan 25, 2024
Merged

fix: fix init not work on pnpm #1334 #1347

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
581a969
fix: fix init not work on pnpm #1334
jmpecx Jan 25, 2024
68cbf6b
doc: pnpm users must run init on project root
jmpecx Jan 25, 2024
45c8e22
Update bin.js
typicode Jan 25, 2024
216295c
Update bin.js
typicode Jan 25, 2024
316df5c
Update get-started.md
typicode Jan 25, 2024
1213876
Merge branch 'main' into patch-2
typicode Jan 25, 2024
f0d6b4f
Merge branch 'main' into patch-2
typicode Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import i from './index.js'
let a = process.argv[2]

if (a == 'init') {
let p = process.env.npm_package_json
let p = 'package.json'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not still use the env, but fallback if missing:

let p = process.env.npm_package_json || 'package.json'

let d = JSON.parse(f.readFileSync(p))
(d.scripts ||= {}).prepare = 'husky'
w('package.json', JSON.stringify(d, null, /\t/.test() ? '\t' : 2) + '\n')
Expand Down