deps: update eslint to v9 (#648)

* deps: update to eslint 9

* Remove unused eslint directives

* ci: add @eslint/* modules to eslint group

.github/dependabot.yml

@@ -23,6 +23,7 @@ updates:
       - "eslint"
       - "eslint-plugin-*"
       - "eslint-config-*"
+      - "@eslint/*"
       - "@typescript-eslint/*"
     passport:
       patterns:

bin/u-wave-core.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 
-/* eslint-disable no-console,n/no-process-exit */
+/* eslint-disable n/no-process-exit */
 import fs from 'node:fs';
 import explain from 'explain-error';
 import Ajv from 'ajv';

package.json

@@ -73,7 +73,7 @@
     "yaml": "^2.0.0"
   },
   "devDependencies": {
-    "@eslint/js": "^8.57.1",
+    "@eslint/js": "^9.12.0",
     "@tsconfig/node18": "^18.2.2",
     "@types/bcryptjs": "^2.4.2",
     "@types/cookie": "^0.6.0",
@@ -104,7 +104,7 @@
     "concat-stream": "^2.0.0",
     "delay": "^6.0.0",
     "dotenv": "^16.0.0",
-    "eslint": "^8.2.0",
+    "eslint": "^9.12.0",
     "eslint-plugin-import": "^2.30.0",
     "eslint-plugin-n": "^17.10.2",
     "get-port": "^7.0.0",

src/Uwave.js

@@ -228,7 +228,7 @@ class UwaveServer extends EventEmitter {
    *     a source plugin factory was passed to `sourcePlugin`.
    */
   source(sourcePlugin, opts = {}) {
-    if (typeof sourcePlugin === 'string') { // eslint-disable-line prefer-rest-params
+    if (typeof sourcePlugin === 'string') {
       return this.#sources.get(sourcePlugin);
     }
 

src/index.js

@@ -1,4 +1,3 @@
-/* eslint-disable import/extensions */
 import Uwave from './Uwave.js';
 import HttpApi from './HttpApi.js';
 import SocketServer from './SocketServer.js';

src/plugins/acl.js

@@ -39,7 +39,6 @@ class Acl {
     if (existingRoles === 0) {
       this.#logger.info('no roles found, adding defaults');
       for (const [roleName, permissions] of Object.entries(defaultRoles)) {
-        // eslint-disable-next-line no-await-in-loop
         await this.createRole(roleName, permissions);
       }
     }

src/plugins/bans.js

@@ -41,7 +41,7 @@ class Bans {
    *
    * @param {User} user A user object.
    */
-  // eslint-disable-next-line class-methods-use-this
+
   async isBanned(user) {
     return isValidBan(user);
   }
@@ -171,7 +171,7 @@ class Bans {
  * @param {import('../Uwave.js').default} uw
  */
 async function bans(uw) {
-  uw.bans = new Bans(uw); // eslint-disable-line no-param-reassign
+  uw.bans = new Bans(uw);
 }
 
 export default bans;

src/plugins/booth.js

@@ -300,7 +300,7 @@ class Booth {
    *
    * @param {PopulateMedia} historyEntry
    */
-  // eslint-disable-next-line class-methods-use-this
+
   getMediaForPlayback(historyEntry) {
     return Object.assign(omit(historyEntry.media, 'sourceData'), {
       media: {

src/plugins/emotes.js

@@ -358,7 +358,7 @@ class Emotes {
  * @returns {Promise<void>}
  */
 async function emotesPlugin(uw) {
-  uw.emotes = new Emotes(uw); // eslint-disable-line no-param-reassign
+  uw.emotes = new Emotes(uw);
   uw.httpApi.use('/emotes', routes());
 }
 

src/plugins/playlists.js

@@ -179,7 +179,7 @@ class PlaylistsRepository {
    * @param {object} patch
    * @returns {Promise<Playlist>}
    */
-  // eslint-disable-next-line class-methods-use-this
+
   async updatePlaylist(playlist, patch = {}) {
     Object.assign(playlist, patch);
     await playlist.save();
@@ -190,7 +190,7 @@ class PlaylistsRepository {
    * @param {Playlist} playlist
    * @returns {Promise<Playlist>}
    */
-  // eslint-disable-next-line class-methods-use-this
+
   async shufflePlaylist(playlist) {
     playlist.media = shuffle(playlist.media);
     await playlist.save();
@@ -201,7 +201,7 @@ class PlaylistsRepository {
    * @param {Playlist} playlist
    * @returns {Promise<void>}
    */
-  // eslint-disable-next-line class-methods-use-this
+
   async deletePlaylist(playlist) {
     await playlist.deleteOne();
   }
@@ -535,7 +535,7 @@ class PlaylistsRepository {
    * @param {object} patch
    * @returns {Promise<PlaylistItem>}
    */
-  // eslint-disable-next-line class-methods-use-this
+
   async updatePlaylistItem(item, patch = {}) {
     Object.assign(item, patch);
     await item.save();
@@ -547,7 +547,7 @@ class PlaylistsRepository {
    * @param {ObjectId[]} itemIDs
    * @param {{ afterID: ObjectId? }} options
    */
-  // eslint-disable-next-line class-methods-use-this
+
   async movePlaylistItems(playlist, itemIDs, { afterID }) {
     // Use a plain array instead of a mongoose array because we need `splice()`.
     const itemsInPlaylist = [...playlist.media];

src/plugins/waitlist.js

@@ -365,7 +365,7 @@ class Waitlist {
  * @returns {Promise<void>}
  */
 async function waitlistPlugin(uw) {
-  uw.waitlist = new Waitlist(uw); // eslint-disable-line no-param-reassign
+  uw.waitlist = new Waitlist(uw);
   uw.httpApi.use('/waitlist', routes());
 }
 

src/sockets/GuestConnection.js

@@ -92,7 +92,6 @@ class GuestConnection extends EventEmitter {
     this.events.remove();
   }
 
-  // eslint-disable-next-line class-methods-use-this
   toString() {
     return 'Guest';
   }

test/sources.mjs

@@ -29,7 +29,7 @@ describe('Media Sources', () => {
     return {
       name: 'test-source',
       search,
-      get: get, // eslint-disable-line object-shorthand
+      get: get,
     };
   }
 

test/utils/deleteDatabase.mjs

@@ -8,22 +8,19 @@ export default async function deleteDatabase(url) {
   const mongo = mongoose.createConnection(url);
   await once(mongo, 'connected');
 
-  /* eslint-disable no-await-in-loop */
   for (let i = 0; i < 50; i += 1) {
     try {
       await mongo.dropDatabase();
       break;
     } catch (error) {
       if (error.code === IN_PROGRESS_ERROR) {
-        // eslint-disable-next-line no-console
         console.log('database op in progress...waiting');
         await delay(100);
       } else {
         throw error;
       }
     }
   }
-  /* eslint-enable no-await-in-loop */
 
   await mongo.close();
 }

test/waitlist.mjs

@@ -58,7 +58,6 @@ describe('Waitlist', () => {
 
       await Promise.all(users.map(createTestPlaylistItem));
       for (const u of users) {
-        // eslint-disable-next-line no-await-in-loop
         await uw.waitlist.addUser(u.id);
       }