Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hooks, support React 18, drop React < 16 #196

Open
wants to merge 15 commits into
base: default
Choose a base branch
from
Open

Conversation

goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented May 1, 2022

Similar to u-wave/react-youtube#117.

This will be version 1.0 of the library.

It uses hooks internally instead of a class. The published code targets modern browsers but you can still transpile it if you need to.

There should be no API changes.

@joshuarcher
Copy link

When do we expect to merge this? And why is it necessary to drop React <= 16

@goto-bus-stop
Copy link
Member Author

No real timeline on merging this, as it's not really that important for end users anyways. The feature set is the same as the class component version from 0.x.

I want to align this release with my other embed modules (especially @u-wave/react-youtube) and the hooks approach has some caveats wrt unmounting and the timing of destroying the player. As it's going to be 1.0, i want to be sure that there are no bugs around that :)

@goto-bus-stop goto-bus-stop marked this pull request as ready for review November 13, 2022 11:12
@goto-bus-stop goto-bus-stop changed the title Use hooks, support React 18, drop React ≤16 Use hooks, support React 18, drop React < 16 Nov 13, 2022
@bnolan001
Copy link

Any updates on when this or the other PRs will be merged?

@goto-bus-stop
Copy link
Member Author

Not currently. are you looking for a particular improvement from this PR?

@bnolan001
Copy link

Having a version number that is 1.0 makes the library an easier sell for usage in a project.

@goto-bus-stop
Copy link
Member Author

I'll aim to finish, test, and release this by the time React 19 comes out.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
weihanglo Weihang Lo

Verified

This commit was signed with the committer’s verified signature. The key has expired.
weihanglo Weihang Lo

Verified

This commit was signed with the committer’s verified signature. The key has expired.
weihanglo Weihang Lo
@goto-bus-stop goto-bus-stop force-pushed the hooks branch 2 times, most recently from 33e47ed to 85a2673 Compare June 30, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants