Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get back open-in-newtab switch by SHIFT key for the logger on mobile #1847

Closed
8 tasks done
Yuki2718 opened this issue Nov 27, 2021 · 2 comments
Closed
8 tasks done

Get back open-in-newtab switch by SHIFT key for the logger on mobile #1847

Yuki2718 opened this issue Nov 27, 2021 · 2 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@Yuki2718
Copy link

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

I know the logger icon on the popup was removed on mobile so now it should be opened via support pane. But now it opens in new window by default on emulated mobile browser. It had been possible to switch the behavior with SHIFT key, but now this is not possible. This may be a personal request but it's inconvinient as I use emulated Android for quick screening of issues and also use a dedicated profile than UA switcher, because I often check both PC and mobile (and both uBO and AG) simultenously - you'll find in my commit history at AG it's not rare both Mobile filters and Base/Japanese filters are edited at the same commit.

A specific URL where the issue occurs

moz-extension://EXTENSION ID/dashboard.html#support.html

Steps to Reproduce

  1. Set general.useragent.override to any of mobile UA such as Mozilla/5.0 (Android 11; Mobile; rv:93.0) Gecko/93.0 Firefox/93.0 on about:config and restart Firefox
  2. Go to Support pane
  3. Open the logger with SHIFT key pushed

Expected behavior

With SHIFT key it should be opened in new tab

Actual behavior

Opened in new window by default if you didn't change before update to 1.39

uBlock Origin version

1.39.0

Browser name and version

Firefox 94.0.2

Operating System and version

Windows 10

@gorhill
Copy link
Member

gorhill commented Nov 27, 2021

Would having to add the token +logger to uiPopupConfig work for you? (The same way it's possible to also add the no-popups switch back in the mobile version of the popup panel.)

@Yuki2718
Copy link
Author

Yeah, if I understand correctly that should fix #1848 as well.

gorhill added a commit to gorhill/uBlock that referenced this issue Nov 27, 2021
Add ability to bring back logger button in popup panel through
the advanced setting `uiPopupConfig`. Adding `+logger` token
to `uiPopupConfig` will bring back the logger icon in the mobile
version of the popup panel.

Additionally, the link to the logger in the Support pane will
take into account whether the <Shift> key is pressed, so as
to behave like the logger icon in the popup panel.

Related issue:
- uBlockOrigin/uBlock-issues#1847

The troubleshooting information has been further fine-tuned to
report popup panel data related to the reported page, for better
diagnosis by disclosing any customization to uBO which was
affecting the reported page.
@gwarser gwarser added enhancement New feature or request fixed issue has been addressed labels Nov 30, 2021
@gwarser gwarser closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants