Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classification of behind-the-scene requests in 1.47.0+? #2515

Closed
8 tasks done
Jee-Hex opened this issue Feb 28, 2023 · 7 comments
Closed
8 tasks done

Classification of behind-the-scene requests in 1.47.0+? #2515

Jee-Hex opened this issue Feb 28, 2023 · 7 comments
Labels
bug Something isn't working fixed issue has been addressed

Comments

@Jee-Hex
Copy link

Jee-Hex commented Feb 28, 2023

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

Requests previously classified as behind-the-scene in the logger are now (potentially) classified as first-party requests and have a partyness of 0,1.

A specific URL where the issue occurs.

N/A

Steps to Reproduce

This is just an example because I don't have a way to reliably trigger behind-the-scene requests other than closing a tab at the right moment since uBO became a WebExtension.

  1. uBO in hard mode.
  2. Install CSS Exfil Protection from AMO.
  3. Open the uBO logger.
  4. Visit https://www.theguardian.com/.

Expected behavior

Two css requests to https://assets.guim.co.uk/stylesheets/... that were blocked by the rule * * 3p block, and subsequent matching xhr requests to the same urls via behind-the-scene (mlgualtieri/CSS-Exfil-Protection#29 (comment)). The partyness of the latter should be (0,3) behind-the-scene ⇒ guim.co.uk according to the logger in 1.46.0.

Actual behavior

Two css requests to https://assets.guim.co.uk/stylesheets/... were blocked by the rule * * 3p block, but assets.guim.co.uk became the context for subsequent matching xhr requests. The partyness of the latter is also reported as (0,1) guim.co.uk ⇒ guim.co.uk in the logger in 1.47.0.

Meanwhile the context and partyness filter updates (which used to be considered behind-the-scene) are correctly
identified as [uBO-uuid].moz-extension-scheme and 0,3 respectively.

uBO version

1.47.0

Browser name and version

Firefox 110

Operating System and version

Windows 10

@gorhill
Copy link
Member

gorhill commented Feb 28, 2023

I don't understand what's the issue:

Screenshot from 2023-02-28 12-33-17

@Jee-Hex
Copy link
Author

Jee-Hex commented Feb 28, 2023

Apologies. I forgot to mention that you will need to select All in the drop-down page selector.

@gorhill
Copy link
Member

gorhill commented Feb 28, 2023

Selecting All changes nothing, and anyways tabless network requests are always reported in the logger regardless of the drop down selector.

@Jee-Hex
Copy link
Author

Jee-Hex commented Feb 28, 2023

I have no idea why it's not reproducing on your end. For some reason it didn't happen on first try, but I can clearly reproduce this with the STR provided on a vanilla Nightly profile.

@gorhill
Copy link
Member

gorhill commented Feb 28, 2023

Ok I was filtering the logger output to see css/font. The problematic requests are xhr though, hence they were filtered out from being reported in the logger.

gorhill added a commit to gorhill/uBlock that referenced this issue Mar 1, 2023
@gorhill
Copy link
Member

gorhill commented Mar 1, 2023

Should be fixed in the latest dev build, and I will include the fix in the next stable revision if all work as expected.

@gwarser
Copy link

gwarser commented Mar 2, 2023

It seems this was also related: uBlockOrigin/uAssets#11128 (comment)

@gwarser gwarser closed this as completed Mar 2, 2023
@gwarser gwarser added bug Something isn't working fixed issue has been addressed labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed issue has been addressed
Projects
None yet
Development

No branches or pull requests

3 participants