Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new set-constant scriptlet values of AdGuard #2615

Closed
piquark6046 opened this issue Apr 27, 2023 · 8 comments
Closed

Support new set-constant scriptlet values of AdGuard #2615

piquark6046 opened this issue Apr 27, 2023 · 8 comments
Labels
enhancement New feature or request fixed issue has been addressed

Comments

@piquark6046
Copy link
Member

piquark6046 commented Apr 27, 2023 •
edited
Loading

Description

The following values are not supported in uBO:

  • noopCallbackFunc
  • throwFunc
  • noopPromiseResolve
  • noopPromiseReject
  • -1
  • yes
  • no

https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-scriptlets.md#set-constant

uBO version

1.49.0

Browser name and version

Mozilla Firefox Developer Edition 113.0b8

Operating System and version

Ubuntu 23.04
@gorhill
Copy link
Member

gorhill commented Apr 27, 2023

I am not seeing instances of set-constant filters using these values. Can I get a sense of usage stats for these?

@piquark6046
Copy link
Member Author

piquark6046 commented Apr 27, 2023 •
edited
Loading

Yep. There are some examples:

@gwarser gwarser added the enhancement New feature or request label Apr 27, 2023
@gorhill
Copy link
Member

gorhill commented May 12, 2023

I want to use a different approach than AdGuard. Instead of introducing new values (noopCallbackFunc, noopPromiseResolve, etc.), I want to introduce new ways to return currently supported values. Examples:

...##+js(set, property, value)
...##+js(set, property, value, asCallback)
...##+js(set, property, value, asResolved)
...##+js(set, property, value, asRejected)
  • The first one behaves as expected: property is set to value
  • The second one would return a function which returns value
  • The third one returns a Promise which resolves to value
  • The fourth one returns a Promise which fails with value

Now I need real world cases where these can be tested.

@piquark6046
Copy link
Member Author

@ameshkov Please take a look.

@ameshkov
Copy link

Good stuff

gwarser referenced this issue in gorhill/uBlock May 17, 2023
@gorhill
Render List stats below on mobile
9ea3988
@gwarser

This comment was marked as outdated.

Sign in to view
@piquark6046 piquark6046 mentioned this issue May 18, 2023
Closed
gorhill added a commit to gorhill/uBlock that referenced this issue May 19, 2023
@gorhill
Expand/harden some scriptlets
2ef2888 
Related issue:
- uBlockOrigin/uBlock-issues#2615

Expand `set-constant`: 3rd parameter and beyond are tokens which
modify the behavior of `set-contant`. Valid tokens:

- `interactive`, `end`, `2`: set the constant when the event
  `DOMContentInteractive` is fired.
- `complete`, `idle`, `3`: set the constant when the event
  `load` is fired.
- `asFunction`: the constant will be a function returning the
  specified value.
- `asCallback`: the constant will be a function returning a
  function returning the specified value.
- `asResolved`: the constant will be a promise resolving to
  the specified value.
- `asRejected`: the constant will be a promise failing with
  the specified value.

Harden `no-setimeout-if` and `no-setinterval-if` as per feedback
from filter list maintainers.
@uBlock-user uBlock-user added the fixed issue has been addressed label Jun 4, 2023
stephenhawk8054 referenced this issue in uBlockOrigin/uAssets Jul 26, 2023
@peace2000
filmweb.pl GDPR dialog
9108057
@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Jul 1, 2024 •
edited
Loading

@gorhill I just realized I don't see the options as (asCallback, asResolved...) in the current code: https://github.com/gorhill/uBlock/blob/master/assets/resources/scriptlets.js . Were they not transferred when switching to vararg approach?

@garry-ut99

This comment was marked as abuse.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request fixed issue has been addressed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@gorhill @gwarser @ameshkov @uBlock-user @stephenhawk8054 @garry-ut99 @piquark6046