Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-prune-fetch-response not working in older Firefox and Chromium versions #2838

Closed
8 tasks done
stephenhawk8054 opened this issue Sep 25, 2023 · 2 comments
Closed
8 tasks done
Labels
wontfix won't be addressed

Comments

@stephenhawk8054
Copy link
Member

stephenhawk8054 commented Sep 25, 2023

Prerequisites

  • I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
  • This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
  • The issue is not present after disabling uBO in the browser.
  • I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

  • uBO is the only extension.
  • uBO uses default lists and settings.
  • using a new, unmodified browser profile.

Description

In Firefox ESR version 102 and Chromium version 103.0.5060.134, json-prune-fetch-response does not work on YouTube.

It works normally on newest Firefox and Chromium stable versions (both are 117).

The current filter being used is

youtube.com,youtubekids.com,youtube-nocookie.com##+js(json-prune-fetch-response, [].playerResponse.adPlacements [].playerResponse.playerAds [].playerResponse.adSlots playerResponse.adPlacements playerResponse.playerAds playerResponse.adSlots adPlacements playerAds adSlots)

I'm not sure from which browser version that the filter starts to work.


The 3 trusted-replace-fetch-response filters still work normally on older browser versions

youtube.com,youtubekids.com,youtube-nocookie.com##+js(trusted-replace-fetch-response, /\"adPlacements.*?\"\}\}\}\]\,/, , player?key=)
youtube.com,youtubekids.com,youtube-nocookie.com##+js(trusted-replace-fetch-response, /\"adSlots.*?\}\]\}\}\]\,/, , player?key=)
youtube.com,youtubekids.com,youtube-nocookie.com##+js(trusted-replace-fetch-response, /\"playerAds.*?\}\}\]\,/, , player?key=)

A specific URL where the issue occurs.

https://www.youtube.com/

Steps to Reproduce

  1. Disable these current 3 filters so it's easier to reproduce
youtube.com,youtubekids.com,youtube-nocookie.com#@#+js(trusted-replace-fetch-response, /\"adPlacements.*?\"\}\}\}\]\,/, , player?key=)
youtube.com,youtubekids.com,youtube-nocookie.com#@#+js(trusted-replace-fetch-response, /\"adSlots.*?\}\]\}\}\]\,/, , player?key=)
youtube.com,youtubekids.com,youtube-nocookie.com#@#+js(trusted-replace-fetch-response, /\"playerAds.*?\}\}\]\,/, , player?key=)
  1. Access https://www.youtube.com/
  2. Click on any video
  3. Click on some videos on the right side bar

(Access youtube link directly or refreshing youtube link won't trigger the issue since the ads are not in fetch response in that case)

Expected behavior

The ads are pruned from the fetch response

Actual behavior

The ads are not pruned from the fetch response

uBO version

1.52.0

Browser name and version

Firefox ESR 102 and Chromium 103.0.5060.134

Operating System and version

Windows 10

@krystian3w
Copy link

krystian3w commented Sep 26, 2023

Firefox release 102 is being extinguished, users should start taking tests to see if they are ready for Firefox 115.3.1.

@uBlock-user uBlock-user added the something to address something to address label Feb 24, 2024
@gorhill
Copy link
Member

gorhill commented Feb 29, 2024

Reality is that I have no motivation to investigate such issues for outdated browsers. Even though these browser versions are officially supported, I can't guarantee that everything works as intended in these, it's just a burden I don't want to take on.

People using older browsers are welcome to put in the work to contribute to the project to help investigate and provide solution to issues specific to their old browser versions. Filter list maintainers are welcome to also refuse to look into such issues when some filters behave differently in older browser versions, and whoever submit reports for such filter issues are welcome to contribute to figure filter solutions in order to unburden filter list maintainers.

Closing as wontfix -- assuming it still is an issue with current stable release of uBO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix won't be addressed
Projects
None yet
Development

No branches or pull requests

4 participants