Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VCC-2970 VCC-2968 Add a select-only variant; add additional keyboard interaction #22

Merged
merged 10 commits into from
Apr 9, 2024
Merged

VCC-2970 VCC-2968 Add a select-only variant; add additional keyboard interaction #22

merged 10 commits into from
Apr 9, 2024

Commits on Apr 2, 2024

  1. Set consistent height in demo Combobo inputs/divs

    Stephy Miehle committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    6fd2d1f View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Update var to const

    Stephy Miehle committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    a8b6d62 View commit details
    Browse the repository at this point in the history

  2. VCC-2970 VCC-2968 Add a select-only variant; add additional keyboard … 

    …interaction

The input is replaced with a `div`, then all of the appropriate interactions and attributes are added to the `div`.

Notably, this also brings a lot of `select`-specific behavior to the `div`. Even though the text input is disabled and not visible, we still have to use familiar patterns.
    Stephy Miehle committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    552b112 View commit details
    Browse the repository at this point in the history

  3. Remove console.log from debugging

    Stephy Miehle committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    58d1ac3 View commit details
    Browse the repository at this point in the history

  4. VCC-2970 Update the for attribute on the label to match the ID on t… 

    …he select/input

When a `<select>` has a paired label (the `<label>`'s for matches the `id` on the `<select>`) or there is a `<label>` directly before a `<select>`, update the `for` to match the `id` of the combobox element
    Stephy Miehle committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    e5fbed6 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Fix text overflow when multiple selections are allowed

    Stephy Miehle committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    4f01c52 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Allow select-only behavior on HTML-initialized comboboxes

    Stephy Miehle committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    110f081 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'vcc-2970/select-only-combobox', remote-tracking branch … 

    …'origin' into vcc-2970/label-for
    Stephy Miehle committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    707f32f View commit details
    Browse the repository at this point in the history

  3. Update the for attribute in transformed select-only <input> comboboxes

    Stephy Miehle committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    4024057 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #23 from uConnect/vcc-2970/label-for 

    VCC-3455 Update the `for` attribute on the label to match the ID on the select/input
    @stephymiehle
    stephymiehle authored Apr 9, 2024
    Configuration menu
    Copy the full SHA
    f5303c7 View commit details
    Browse the repository at this point in the history