Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added case-insensitive flag for Instagram regex #448

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added case-insensitive flag for Instagram regex #448

wants to merge 1 commit into from

Conversation

k-egor-smirnov
Copy link

I'm receiving lowercase Instagram useragents. I've added it to regexes.yaml, but test failing because tool doesn't count regex_flag property. Also, I didn't found regex_flag property in other UA useragents and I'm not sure that my changes is correct

elsigh
elsigh requested changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@elsigh elsigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just include[Ii] to get both characters in the regex without that flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsigh elsigh elsigh requested changes

Assignees
No one assigned
Labels
needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-egor-smirnov @elsigh @commenthol