Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Radio Thmanyah as Podcast Catcher #568

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ node_modules/
package-lock.json
*.tgz
*.log
.prettierignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure about that one, .vscode. makes sense though

.vscode
12 changes: 12 additions & 0 deletions regexes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ user_agent_parsers:
- regex: 'ArcGIS\.Runtime\.(Qt)\.(\d+)\.(\d+)(?:\.(\d+)|)'
family_replacement: 'ArcGIS Runtime SDK for $1'

#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

# CFNetwork Podcast catcher Applications
- regex: '^(Luminary)[Stage]+/(\d+) CFNetwork'
- regex: '(ESPN)[%20| ]+Radio/(\d+)\.(\d+)\.(\d+) CFNetwork'
Expand All @@ -68,6 +69,17 @@ user_agent_parsers:
family_replacement: 'AudioBoom'
- regex: ' (Rivo) RHYTHM'

# Radio Thmanyah Podcast Catcher
- regex: '(Radio Thmanyah)/(\d+)\.(\d+)\.(\d+)'
family_replacement: 'Radio Thmanyah'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line not needed, as you use a capture group with the same value

- regex: '(Radio Thmanyah ar)/(\d+)\.(\d+)\.(\d+)'
family_replacement: 'راديو ثمانية'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, can the family be written in non-utf8 characters? (i.e. why do we need the arabic distinction)

- regex: '(Radio Thmanyah Android)/(\d+)\.(\d+)\.(\d+)'
family_replacement: 'Radio Thmanyah Android'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line not needed, as you use a capture group with the same value

- regex: '(Radio Thmanyah iOS)/(\d+)\.(\d+)\.(\d+)'
family_replacement: 'Radio Thmanyah iOS'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line not needed, as you use a capture group with the same value



# @note: iOS / OSX Applications
- regex: '(CFNetwork)(?:/(\d+)\.(\d+)(?:\.(\d+)|)|)'
family_replacement: 'CFNetwork'
Expand Down
24 changes: 24 additions & 0 deletions tests/test_ua.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8681,3 +8681,27 @@ test_cases:
major: '3'
minor: '2'
patch: '1'

- user_agent_string: 'Radio Thmanyah/1.0.2'
family: 'Radio Thmanyah'
major: '1'
minor: '0'
patch: '2'

- user_agent_string: 'Radio Thmanyah ar/1.0.2'
family: 'راديو ثمانية'
major: '1'
minor: '0'
patch: '2'

- user_agent_string: 'Radio Thmanyah Android/1.0.2'
family: "Radio Thmanyah Android"
major: '1'
minor: '0'
patch: '2'

- user_agent_string: 'Radio Thmanyah iOS/1.0.2'
family: "Radio Thmanyah iOS"
major: '1'
minor: '0'
patch: '2'