This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Updating for server compatibility with fixes for reply network messages #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,12 +17,16 @@ class ScopeFetchReplyMessage: ReplyMessage { | |||
| return ScopeFetchReplyMessage.messageType | |||
| } | |||
|
|
|||
| let success: Bool | |||
There was a problem hiding this comment.
So I was thinking that the absence of an error means that it was successful (wiki also updated with this)
There was a problem hiding this comment.
Yeah it's just weird that SessionCreateReplyMessage has success and this does not
There was a problem hiding this comment.
Acording to the Wiki it doesn't;) Maybe remove to success flag from SessionCreateReplyMessage, too?
added 4 commits
November 11, 2014 17:40
Conflicts: JetstreamTests/StateMessageTests.swift JetstreamTests/TransactionTests.swift
|
LGTM! |
artman
added a commit
that referenced
this pull request
Nov 12, 2014
Updating for server compatibility with fixes for reply network messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.