Make the string form of "invisible" RepositoryNames stand out

These invalid RepositoryName objects often are often hidden in labels, which means that a label with an invalid RepositoryName could have a perfectly normal looking string form like "@foo//bar". With this change, it would look like "@[unknown repo 'foo' requested from @mod~1.0]//bar", making it immediately stand out and saving debugging time. PiperOrigin-RevId: 470961893 Change-Id: Ie48d788660aca76cb8a5e4f5138d9caad51b08ee
uber-common · Aug 30, 2022 · a71ebc1 · a71ebc1
1 parent 535f9d7
commit a71ebc1
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/cmdline/RepositoryName.java b/src/main/java/com/google/devtools/build/lib/cmdline/RepositoryName.java
@@ -199,13 +199,17 @@ public RepositoryName getOwnerRepoIfNotVisible() {
     return ownerRepoIfNotVisible;
   }
 
-  /** Returns if this is the main repository, that is, {@link #getName} is empty. */
+  /** Returns if this is the main repository. */
   public boolean isMain() {
-    return name.isEmpty();
+    return equals(MAIN);
   }
 
   /** Returns the repository name, with leading "{@literal @}". */
   public String getNameWithAt() {
+    if (!isVisible()) {
+      return String.format(
+          "@[unknown repo '%s' requested from %s]", name, ownerRepoIfNotVisible.getNameWithAt());
+    }
     return '@' + name;
   }
 

diff --git a/src/main/java/com/google/devtools/build/lib/cmdline/TargetPattern.java b/src/main/java/com/google/devtools/build/lib/cmdline/TargetPattern.java
@@ -921,8 +921,8 @@ public TargetPattern parse(String pattern) throws TargetParsingException {
         if (!repository.isVisible()) {
           throw new TargetParsingException(
               String.format(
-                  "Repository '%s' is not visible from repository '@%s'",
-                  repository.getNameWithAt(), repository.getOwnerRepoIfNotVisible()),
+                  "Repository '@%s' is not visible from repository '@%s'",
+                  repository.getName(), repository.getOwnerRepoIfNotVisible()),
               Code.PACKAGE_NOT_FOUND);
         }
 

diff --git a/...main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java b/...main/java/com/google/devtools/build/lib/rules/repository/RepositoryDelegatorFunction.java
@@ -245,9 +245,8 @@ public SkyValue compute(SkyKey skyKey, Environment env)
     if (!repositoryName.isVisible()) {
       return new NoRepositoryDirectoryValue(
           String.format(
-              "Repository '%s' is not visible from repository '%s'",
-              repositoryName.getNameWithAt(),
-              repositoryName.getOwnerRepoIfNotVisible().getNameWithAt()));
+              "Repository '@%s' is not visible from repository '%s'",
+              repositoryName.getName(), repositoryName.getOwnerRepoIfNotVisible().getNameWithAt()));
     }
 
     Map<RepositoryName, PathFragment> overrides = REPOSITORY_OVERRIDES.get(env);

diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java
@@ -102,8 +102,8 @@ public SkyValue compute(SkyKey skyKey, Environment env)
       return new PackageLookupValue.NoRepositoryPackageLookupValue(
           repoName.getNameWithAt(),
           String.format(
-              "Repository '%s' is not visible from repository '%s'",
-              repoName.getNameWithAt(), repoName.getOwnerRepoIfNotVisible().getNameWithAt()));
+              "Repository '@%s' is not visible from repository '%s'",
+              repoName.getName(), repoName.getOwnerRepoIfNotVisible().getNameWithAt()));
     }
 
     if (deletedPackages.get().contains(packageKey)) {