Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run lint on 1.12, remove pre-1.11 versions #52

Merged
merged 3 commits into from
May 1, 2019
Merged

Run lint on 1.12, remove pre-1.11 versions #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbf8bfb
Run lint on 1.12, remove pre-1.11 versions
prashantv May 1, 2019
dbaf9f6
Use go list ./... for golint
prashantv May 1, 2019
b6a4e5a
Makefiles
prashantv May 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,12 @@ language: go
go_import_path: go.uber.org/atomic

go:
- 1.7.x
- 1.8.x
- 1.9.x
- 1.10.x
- 1.11.x
- 1.x # latest release
- 1.12.x

matrix:
include:
- go: 1.11.x
- go: 1.12.x
env: NO_TEST=yes LINT=yes

cache:
Expand Down
9 changes: 4 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
PACKAGES := $(shell glide nv)
# Many Go tools take file globs or directories as arguments instead of packages.
PACKAGE_FILES ?= *.go

Expand All @@ -8,7 +7,7 @@ export GO15VENDOREXPERIMENT=1

.PHONY: build
build:
go build -i $(PACKAGES)
go build -i ./...


.PHONY: install
Expand All @@ -19,7 +18,7 @@ install:

.PHONY: test
test:
go test -cover -race $(PACKAGES)
go test -cover -race ./...


.PHONY: install_ci
Expand All @@ -39,9 +38,9 @@ lint:
@echo "Checking formatting..."
@gofmt -d -s $(PACKAGE_FILES) 2>&1 | tee lint.log
@echo "Checking vet..."
@$(foreach dir,$(PACKAGE_FILES),go tool vet $(dir) 2>&1 | tee -a lint.log;)
@go vet ./... 2>&1 | tee -a lint.log;)
@echo "Checking lint..."
@$(foreach dir,$(PKGS),golint $(dir) 2>&1 | tee -a lint.log;)
@golint $$(go list ./...) 2>&1 | tee -a lint.log
@echo "Checking for unresolved FIXMEs..."
@git grep -i fixme | grep -v -e vendor -e Makefile | tee -a lint.log
@[ ! -s lint.log ]
Expand Down