Modify Bool to only use 1 or 0, rater than last bit #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most methods of Bool currently rely on the last bit, but `CAS` generates the int value to match `old` based on the user's input and so it assumes the value is either `1` or `0`. The only reason we relid on the last bit is that `Toggle` was implemented using an atomic add. We can instead implement `Toggle` using a loop around `CAS`. Fixes #61.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 145 148 +3
=====================================
+ Hits 145 148 +3
Continue to review full report at Codecov.
|
abhinav
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most methods of Bool currently rely on the last bit, but
CASgenerates the int value to match
oldbased on the user's inputand so it assumes the value is either
1or0.The only reason we relid on the last bit is that
Togglewasimplemented using an atomic add. We can instead implement
Toggleusing a loop aroundCAS.Fixes #61.