Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix division by zero #71

Merged
merged 7 commits into from
Jun 18, 2023
Merged

Fix division by zero #71

merged 7 commits into from
Jun 18, 2023

Conversation

Zamony
Copy link
Contributor

@Zamony Zamony commented Jun 6, 2023

This PR fixes divisions by zero.

@CLAassistant
Copy link

CLAassistant commented Jun 6, 2023

CLA assistant check
All committers have signed the CLA.

@Zamony
Copy link
Contributor Author

Zamony commented Jun 7, 2023

I don't get why the license check linter has failed. I haven't changed the license lines at the top of the file.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #71 (1925c28) into master (f6364fc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   93.30%   93.36%   +0.05%     
==========================================
  Files           9        9              
  Lines         224      226       +2     
==========================================
+ Hits          209      211       +2     
  Misses         11       11              
  Partials        4        4              
Impacted Files Coverage Δ
internal/cgroups/cgroups.go 96.42% <100.00%> (ø)
internal/cgroups/cgroups2.go 96.42% <100.00%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sywhang sywhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Do you mind adding a test case for this?

I don't get why the license check linter has failed. I haven't changed the license lines at the top of the file.

I think that was a temporary CI error, I re-ran it and it seems ok.

@Zamony
Copy link
Contributor Author

Zamony commented Jun 8, 2023

Do you mind adding a test case for this?

Sure. Added tests for each of the cases.

@sywhang sywhang merged commit d064ede into uber-go:master Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants