-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix division by zero #71
Conversation
I don't get why the license check linter has failed. I haven't changed the license lines at the top of the file. |
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 93.30% 93.36% +0.05%
==========================================
Files 9 9
Lines 224 226 +2
==========================================
+ Hits 209 211 +2
Misses 11 11
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. Do you mind adding a test case for this?
I don't get why the license check linter has failed. I haven't changed the license lines at the top of the file.
I think that was a temporary CI error, I re-ran it and it seems ok.
Sure. Added tests for each of the cases. |
This PR fixes divisions by zero.