Added the Activity Registration required failure scenario to replayer test suite #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groxx
reviewed
Mar 16, 2023
Groxx
requested changes
Mar 17, 2023
There was a problem hiding this comment.
I've got some changes coming in another PR (not yet up, tackling other things first), but to follow those changes:
- no mixedCase files, use snake_case. both because it's a Go convention and because it consistently avoids case-(in)sensitive-filesystem issues.
- make sure you actually run these, apparently they're not run by our
Makefile:| oops.
…his is an expected behaviour and test is included for documentation purposes.
Groxx
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new workflow and a test case in the replayer test suite.
The new workflow demonstrates how failing to register a new activity throws a non deterministic error.
This reinforces the requirement of RegisterActivityWithOption option in the replayer.
Why?
Made these changes to remember that the replayer requires a new feature.
How did you test it?
tested locally.
Potential risks
NA