Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app.go: Take a pass over the godoc #1162

Merged
merged 4 commits into from
Feb 20, 2024
Merged

app.go: Take a pass over the godoc #1162

merged 4 commits into from
Feb 20, 2024

Commits on Feb 17, 2024

  1. app.go: Take a pass over the godoc 

    The godocs for most of the public API in app.go hasn't been touched in a
while.
I took a quick pass over it to adjust it better to current
recommendations and best practices.
This also makes more use of Go's `[..]` linking.

One notable change: Instead of Options, logical groups of options are
now recomended via Module.
    @abhinav
    abhinav committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    e5fb0a0 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Jacob Oaks <jacoboaks.8@gmail.com>
    @abhinav @JacobOaks
    abhinav and JacobOaks authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    8633a29 View commit details
    Browse the repository at this point in the history

  2. no decorate overload

    @abhinav
    abhinav committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    7396b56 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into abg/doc-pass

    @abhinav
    abhinav authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    ddc24fe View commit details
    Browse the repository at this point in the history