CI: test against go1.22 #1195
Merged
CI: test against go1.22 #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR modifies CI to test against Go versions 1.21 and 1.22. To avoid forcing users to upgrade to 1.21, I kept `go.mod` version at `1.20.` Some tests had to be updated to pass in 1.22. I can remove `stack_120_test.go` if there's a good argument for it, but my thoughts are that we should have a complete & passing test suite for every version >= `go.mod`'s version.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1195 +/- ##
==========================================
- Coverage 98.73% 98.49% -0.25%
==========================================
Files 31 34 +3
Lines 2851 2858 +7
==========================================
Hits 2815 2815
- Misses 29 36 +7
Partials 7 7 ☔ View full report in Codecov by Sentry. |
sywhang
approved these changes
Apr 29, 2024
rabbbit
reviewed
Apr 29, 2024
| @@ -19,7 +19,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| os: ["ubuntu-latest", "windows-latest"] | |||
| go: ["1.20.x", "1.21.x"] | |||
| go: ["1.21.x", "1.22.x"] | |||
There was a problem hiding this comment.
I recently learned a trick via uber-go/tally#258 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies CI to test against Go versions 1.21 and 1.22. To avoid forcing users to upgrade to 1.21, I kept
go.modversion at1.20.Some tests had to be updated to pass in 1.22.
I can remove
stack_120_test.goif there's a good argument for it, but my thoughts are that we should have a complete & passing test suite for every version >=go.mod's version.