Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog duplicate entry #1233

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Aug 26, 2024

For some reason #1229 added duplicate entry for 1.22.2

For some reason uber-go#1229 added duplicate entry for 1.22.2
@sywhang sywhang requested a review from JacobOaks August 26, 2024 21:14
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (432521e) to head (75f5bff).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1233   +/-   ##
=======================================
  Coverage   98.42%   98.42%           
=======================================
  Files          35       35           
  Lines        2918     2918           
=======================================
  Hits         2872     2872           
  Misses         38       38           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JacobOaks
Copy link
Contributor

Can you fix version.go too?

@sywhang
Copy link
Contributor Author

sywhang commented Aug 26, 2024

fixed

Copy link
Contributor

@JacobOaks JacobOaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, not sure how that happened.

@sywhang sywhang merged commit f195420 into uber-go:master Aug 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants