Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint: replace deprecated golang.org/x/lint/golint with golangci-lint #95

Closed
wants to merge 1 commit into from
Closed

lint: replace deprecated golang.org/x/lint/golint with golangci-lint #95

wants to merge 1 commit into from

Commits on Feb 3, 2023

  1. lint: replace deprecated golang.org/x/lint/golint with golangci-lint 

    golint is deprecated. golangci-lint is a more than adequate
replacement. Because it combines different linters, a single invocation in the
Makefile is enough and then produces consistent output for all of them.

It also gets enabled as a GitHub action. This will annotate pull requests.

The godox linter gets enabled as replacement for the manual "grep -i fixme".

For the sake of convenience, "make lint" installs golangci-lint. In contrast to
golint before, this is done without polluting the go.mod file with the extra
dependencies.
    @pohly
    pohly committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    2b5723b View commit details
    Browse the repository at this point in the history