Test and lint against Go 1.19 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Go 1.19 to the test matrix, and switch linting to Go 1.19 since we prefer to lint with the latest stable release. With Go 1.19, we need to: - Update tools dependencies - Fix any use of ioutil - gofmt all files to match new godoc format
r-hang
reviewed
Aug 12, 2022
| @@ -13,9 +13,9 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| go: ["1.17.x", "1.18.x"] | |||
| go: ["1.17.x", "1.18.x", "1.19.x"] | |||
There was a problem hiding this comment.
We haven't been dropping 1.17 from any other package just yet because 1.19 is super new and there's a good chance that many users haven't migrated to 1.18 just yet.
But yes, we should drop this in a future change.
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 108 108
=========================================
Hits 108 108
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sywhang
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Go 1.19 to the test matrix, and switch linting to Go 1.19 since we
prefer to lint with the latest stable release.
With Go 1.19, we need to: