Pool the buffer and encoder used for generic JSON reflection #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
- Coverage 97.47% 97.29% -0.18%
==========================================
Files 39 39
Lines 2017 2035 +18
==========================================
+ Hits 1966 1980 +14
- Misses 43 47 +4
Partials 8 8
Continue to review full report at Codecov.
|
jcorbin
force-pushed
the
pool_reflected_buf
branch
from
ae8d2a1 to
930a571
Compare
akshayjshah
reviewed
Jun 20, 2018
| buf.Free() | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
Similar tests already exist in the top-level zap package; would we be better off changing the Makefile to pass coverpkg=all instead of adding a new test suite?
There was a problem hiding this comment.
For future reviewers: this turned into a yak shave, will fix it later.
jcorbin
force-pushed
the
pool_reflected_buf
branch
from
13daf8a to
9affa89
Compare
|
Hmm, that |
jcorbin
force-pushed
the
pool_reflected_buf
branch
from
9affa89 to
63a5674
Compare
added 5 commits
June 26, 2018 12:58
…ode coverage numbers
jcorbin
force-pushed
the
pool_reflected_buf
branch
from
63a5674 to
93e77b2
Compare
akshayjshah
approved these changes
Jun 26, 2018
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
…#602) Pool buffers and encoders to make JSON reflection less expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.