Drop library level constraints on tools #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This renames tools.go to tools_test.go so that tool/development dependencies are not considered transitive dependencies by `go mod`. (We upgrade multierr and atomic to the most recent releases with a similar fix.) Refs T5279939
This adds staticcheck as a linter to Zap and fixes issues found by it. Specifically, it found a few unused unexported types and functions.
Codecov Report
@@ Coverage Diff @@
## master #795 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 43 43
Lines 2310 2310
=======================================
Hits 2271 2271
Misses 32 32
Partials 7 7 Continue to review full report at Codecov.
|
prashantv
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames tools.go to tools_test.go so that tool/development
dependencies are not considered transitive dependencies by
go mod.(We upgrade multierr and atomic to the most recent releases with a similar
fix.)
While at it, this also adds staticcheck to lint Zap.
Refs T5279939