zapcore: Add Buffered Writer #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Prashant Varanasi <github@prashantv.com>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
…k on loadConfig if needed
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
Co-authored-by: Abhinav Gupta <mail@abhinavg.net>
…case for wrap twice sync
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
+ Coverage 98.12% 98.18% +0.06%
==========================================
Files 44 45 +1
Lines 1975 2041 +66
==========================================
+ Hits 1938 2004 +66
Misses 29 29
Partials 8 8
Continue to review full report at Codecov.
|
These methods should not panic if called without `Write` first (which is what starts the background goroutine).
Writing `BufferedWriteSyncer{WriteSyncer: ...}` is a mouthful. Let's
go for something short and obvious like:
```
package io
type LimitedReader struct {
R Reader // underlying reader
N int64 // max bytes remaining
}
```
abhinav
commented
Jun 8, 2021
prashantv
approved these changes
Jun 8, 2021
|
This is awesome! Glad to see that buffering finally made it in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a BufferedWriteSyncer that buffers writes in memory before flushing
them to the underlying WriteSyncer at some interval or when a
configured amount of data has been buffered -- whichever comes first.
This is a copy of #952 (which itself is a fork of #782) because it was
accidentally merged instead of squashed, and wasn't yet fully reviewed.