Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor converters to be the native implementation, make old to() APIs delegate to them. #188

Closed
5 tasks done
ZacSweers opened this issue Mar 27, 2018 · 9 comments
Closed
5 tasks done

Comments

@ZacSweers
Copy link
Collaborator

ZacSweers commented Mar 27, 2018

So currently, every as()-based converter API just wraps the old to()-based scoper APIs. This works, but in 1.0 we're going to want to remove the old to() based APIs, so as an intermediary let's flip this in 0.8.0. This release'll be a non-API changing release, and totally just flip these internals as an incremental update.

These can/should be done incrementally, and should be modeled after parallelflowable's implementation. It's ok if the scopers are a bit verbose in the meantime or even duplicated functionality. The main goal here is to get the as() APIs fully migrated so that 1.0 is just removing the old scopers. No tests or extension artifacts (android, rxlifecycle) should be changed in this process to ensure the public API is not changing.

  • ObservableConverter/ObservableScoper
  • SingleConverter/SingleScoper
  • MaybeConverter/MaybeScoper
  • CompletableConverter/CompletableScoper
  • FlowableConverter/FlowableScoper
@ZacSweers ZacSweers added this to the 0.8.0 milestone Mar 27, 2018
@ZacSweers ZacSweers self-assigned this Mar 27, 2018
@ZacSweers
Copy link
Collaborator Author

I'll do one of these initially to set a guideline, then try to leave the rest up for some contributors (I know there's a few people interested)

CC @atexannamedbob @VisheshVadhera @tyvsmith

@ZacSweers
Copy link
Collaborator Author

First one is up in #189. Once that's merged, others should feel free to claim remaining ones

@VisheshVadhera
Copy link
Contributor

@hzsweers #189 looks great. Would love to open a PR for the remaining ones, once the the first one gets merged.

@ZacSweers
Copy link
Collaborator Author

First one is down and stencil is in place. @VisheshVadhera if you could just pick one to start, want to leave the rest for others to pick up if interested :)

@VisheshVadhera
Copy link
Contributor

VisheshVadhera commented Mar 28, 2018 via email

@atexannamedbob
Copy link
Contributor

atexannamedbob commented Mar 28, 2018

@hzsweers @VisheshVadhera
I'll take on
CompletableConverter/CompletableScoper

@ZacSweers
Copy link
Collaborator Author

I'm going to move forward with this so we can isolate the next release around it. @VisheshVadhera I'll do SingleObserver last in case you have time to come around to it, but going to do this in the next few days

@VisheshVadhera
Copy link
Contributor

@hzsweers Sounds good. I'll open the PR for SingleObserver tonight!

@ZacSweers
Copy link
Collaborator Author

This is done now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants