Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LifecycleScopeProvider from lint/error prone built-ins #305

Closed
ZacSweers opened this issue Dec 4, 2018 · 0 comments
Closed

Remove LifecycleScopeProvider from lint/error prone built-ins #305

ZacSweers opened this issue Dec 4, 2018 · 0 comments
Labels
Static analysis
Milestone
1.1.0

Comments

@ZacSweers
Copy link
Collaborator

This is redundant if we check for ScopeProvider
@ZacSweers ZacSweers added this to the 1.1.0 milestone Dec 4, 2018
@ShaishavGandhi ShaishavGandhi mentioned this issue Dec 5, 2018
Merged
ShaishavGandhi added a commit that referenced this issue Dec 5, 2018
@ShaishavGandhi
Remove redundant LifecycleScopeProvider static analysis checks (#306)
f430cd7 
**Description**: `LifecycleScopeProvider` extends `ScopeProvider` so it's covered for the static analysis checks. 

Resolves #305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Static analysis
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@ZacSweers