Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few nullability and other minor warnings #187

Merged
merged 8 commits into from
Mar 22, 2018
Merged

Fix a few nullability and other minor warnings #187

merged 8 commits into from
Mar 22, 2018

Commits on Mar 21, 2018

  1. add missing nullability annotations 

    (cherry picked from commit 627a7b9)
    Ben Sandee committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    284bf26 View commit details
    Browse the repository at this point in the history

  2. initial value of matchFound was never used (warning) 

    (cherry picked from commit 5ef7c16)
    Ben Sandee committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    d703b85 View commit details
    Browse the repository at this point in the history

  3. Suppress warning about unchecked assignment. It's a valid case here. 

    (cherry picked from commit 065fe19)
    Ben Sandee committed Mar 21, 2018
    Configuration menu
    Copy the full SHA
    060cfeb View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2018

  1. clarify reason for null check

    Ben Sandee committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    471cbe8 View commit details
    Browse the repository at this point in the history

  2. add comment documenting reason for suppression

    Ben Sandee committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    741c46e View commit details
    Browse the repository at this point in the history

  3. remove unnecessary comment

    Ben Sandee committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    bc22132 View commit details
    Browse the repository at this point in the history

  4. remove comment and suppression

    Ben Sandee committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    2f55598 View commit details
    Browse the repository at this point in the history

  5. fix line length (checkstyle)

    Ben Sandee committed Mar 22, 2018
    Configuration menu
    Copy the full SHA
    deb5b3d View commit details
    Browse the repository at this point in the history