Consolidate Sample #226
Consolidate Sample #226
Conversation
Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
| @@ -20,4 +20,7 @@ | |||
| <string name="title_activity_main">AutoDispose Demo</string> | |||
| <string name="title_activity_arch_component">AutoDispose ArchComponents Demo</string> | |||
| <string name="load_image">Load Image</string> | |||
| <string name="main_activity_description">Sample Java Activity which uses Architecture Components lifecycle to manage subscription</string> | |||
There was a problem hiding this comment.
Tentative descriptions for each Activity. Welcome any feedback!
There was a problem hiding this comment.
How about Sample Java Activity demonstrating integration with Architecture Components Lifecycle?
|
|
||
| val mainActivityButton: Button = findViewById(R.id.mainActivityButton) | ||
| mainActivityButton.setOnClickListener { | ||
| startActivity(MainActivity::class.java) |
There was a problem hiding this comment.
Proposal to rename MainActivity to JavaActivity or something similar?
|
Would you mind adding a screenshot(s) or screenrecording of the new UI for posterity? |
|
Here's a screenshot:
Just opens up the Activities. One concern is that both |
|
Nit: Can we remove the "AutoDispose" prefix in the button texts in favor of just a toolbar with |
Signed-off-by: shaishavgandhi05 <shaishgandhi@gmail.com>
|
Here's the new screenshot: |
|
thanks! |
Description: Consolidate sample to open up different activities. Have also included a brief description before the Button to describe the sample.