Add MainThreadDisposable to allow disposing on the JVM #232
Conversation
|
|
remcomokveld
force-pushed
the
mainThreadDisposable
branch
from
3856b30
to
812cf12
Compare
| @@ -0,0 +1,58 @@ | |||
| /* | |||
| * Copyright (c) 2017. Uber Technologies | |||
There was a problem hiding this comment.
Since this is from rxandroid, let's preserve the header from it
| /** | ||
| * Copy of the MainThreadDisposable from RxAndroid which makes use of the | ||
| * {@link AutoDisposeAndroidUtil} to check for main thread. This allows | ||
| * disposing on the JVM crashing due to the looper check. |
There was a problem hiding this comment.
Nit: I think this sentence is missing a word?
|
|
||
| import java.util.concurrent.atomic.AtomicBoolean; | ||
|
|
||
| import static org.junit.Assert.assertTrue; |
There was a problem hiding this comment.
Nit: mind using Truth instead like the other tests?
| protected void onDispose() { } | ||
| }.dispose(); | ||
| throw new AssertionError("Expected to fail before this due to Looper not being stubbed!"); | ||
| } catch (RuntimeException e) { |
There was a problem hiding this comment.
Could we make this more specific? Since this is a super specific test case, I'm kind of fine with having something specific. Even just something simple like "contains "stub"" or something simple to smoke test it
| }.dispose(); | ||
|
|
||
| assertTrue(called.get()); | ||
| AutoDisposeAndroidPlugins.setOnCheckMainThread(null); |
There was a problem hiding this comment.
Nit: just put this in a before/after block in the test
@Before @After public void resetPlugins() {
AutoDisposeAndroidPlugins.reset();
}
| @@ -0,0 +1,60 @@ | |||
| /* | |||
| * Licensed under the Apache License, Version 2.0 (the "License"); | |||
There was a problem hiding this comment.
nit: this should mention uber
There was a problem hiding this comment.
nvm, saw it's copied too
|
|
||
| public final class MainThreadDisposableTest { | ||
|
|
||
| @Test public void onDisposeRunsSyncWhenMainThreadSkipped() { |
There was a problem hiding this comment.
This title is a little unclear to me. How about onDispose_defersToMainThreadHook?
|
Finishing this up in #235 |
Description:
Due to
LifecycleEventsObservableextending theMainThreadDisposablefromRxAndroidit was not possible to test disposing of a subscription on the JVM.io.reactivex.android.MainThreadObservablealso contains a checkLooper.myLooper() == Looper.getMainLooper()which will throw an exception in JVM tests.Using a local copy of
MainThreadObservablewhich utilizes theAutoDisposeAndroidUtil.isMainThread()you will get more consistent "main thread check" behavior.The unit tests that are now included only test new behavior and not the rest of the behavior of
MainThreadObservable. First wanted to copy over tests from rxandroid, but then saw that those are robolectric, which is not a dependency in this project.