Add automatic-module-name to relevant modules #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 21, 2018 21:17
This has been bothering me, and moving while we're at it. Not breaking since it's expected to be pick up via ServiceLoader and not a dependency
ZacSweers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in http://branchandbound.net/blog/java/2017/12/automatic-module-name/
I'm not totally sure what to do with the ktx artifacts, as they're all purely extension functions but technically don't have different root packages. Open to suggestions. The android artifacts also have this applied, though more fore completeness since Android doesn't support java 9 anyway.
Also opportunistically fixed the error prone checker package from
error.prone.checkerto justerrorprone. Previous name was unnecessarily pedantic and should be ok as far as semver goes since it's not supposed to be a dependency or manually wired anywhere