Add additional extension methods for android-archcomponents #348
Conversation
| * subscription will be disposed. | ||
| */ | ||
| @CheckReturnValue | ||
| inline fun <T> Flowable<T>.autoDisposable(lifecycleOwner: LifecycleOwner, untilEvent: Event): FlowableSubscribeProxy<T> = |
There was a problem hiding this comment.
Let's default the untilEvent to something sensible and then just have one overload?
There was a problem hiding this comment.
Can we really default an untilEvent reliably for everyone? Usually the untilEvent is inferred from when in the lifecycle you subscribe. However that inference logic is private in AndroidLifecycleScopeProvider.
There was a problem hiding this comment.
I'd be fine with it package private
Thought about it but I meant to keep that file as a dumping ground for testing Kotlin compatibility. When I add the |
|
Works for me! |
...mponents/src/androidTest/java/com/uber/autodispose/android/lifecycle/KotlinExtensionsTest.kt
Outdated
Show resolved
Hide resolved
...mponents/src/androidTest/java/com/uber/autodispose/android/lifecycle/KotlinExtensionsTest.kt
Outdated
Show resolved
Hide resolved
...mponents/src/androidTest/java/com/uber/autodispose/android/lifecycle/KotlinExtensionsTest.kt
Outdated
Show resolved
Hide resolved
...s/src/main/java/com/uber/autodispose/android/lifecycle/internal/CorrespondingEventsUtil.java
Outdated
Show resolved
Hide resolved
| @@ -31,7 +33,7 @@ import java.util.concurrent.TimeUnit | |||
| * Test Activity class to verify compilation of various extension functions. | |||
| */ | |||
| @Ignore("Since it's only used to verify compilation of the extension functions") | |||
| class TestKotlinActivity : AppCompatActivity() { | |||
| class TestKotlinActivity : AppCompatActivity(), ScopeProvider { | |||
There was a problem hiding this comment.
Just to doubly confirm - it doesn't get confused about ambiguous types here if targeting this now?
There was a problem hiding this comment.
No, it doesn't. Basically, it will always just resolve to one of those extension functions. It will ask you for one of them. If you're overloading with the untilEvent, it will always resolve to the one with LifecycleOwner.
...roid-archcomponents/src/main/java/com/uber/autodispose/android/lifecycle/KotlinExtensions.kt
Show resolved
Hide resolved
...roid-archcomponents/src/main/java/com/uber/autodispose/android/lifecycle/KotlinExtensions.kt
Outdated
Show resolved
Hide resolved
|
Couple nits but LGTM! |
Part of #347
I've added an additional
TestKotlinActivityin thesamplejust to test out the compilation of extension methods.