Support withScope() in AutoDisposeDetector #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for users to call return or other escapes within its context
ShaishavGandhi
approved these changes
Sep 18, 2019
| method.containingClass?.qualifiedName == KOTLIN_EXTENSIONS) { | ||
| val args = node.valueArguments | ||
| if (args.size == 2) { | ||
| val last = args[1] |
There was a problem hiding this comment.
Can also do args.last() i believe.
There was a problem hiding this comment.
That does an extra size check, which we can skip in this case
...alysis/autodispose-lint/src/test/kotlin/com/uber/autodispose/lint/AutoDisposeDetectorTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the new
withScope()API inAutoDisposeDetector. This works by detecting when that function is called, and then visits the contents of the lambda argument passed to it with the same machinery we used before. This refactors out that machinery a bit to allow defining a custom "isInScope" check, and in the case ofwithScope()it's just hardcoded totruewhen it checks if an enclosed subscribe() call is made in a scope