Sample app! #97
Sample app! #97
Conversation
| private static Function<ActivityEvent, ActivityEvent> CORRESPONDING_EVENTS = | ||
| new Function<ActivityEvent, ActivityEvent>() { | ||
| @Override public ActivityEvent apply(ActivityEvent activityEvent) throws Exception { | ||
| switch (activityEvent) { |
There was a problem hiding this comment.
I'd split these events into two separate sequences, so it'll be easier to understand, why startup methods have symmetric shutdown ones as a counterpart, while shutdown methods are having sequential shutdown ones.
| implements LifecycleScopeProvider<AutoDisposeFragment.FragmentEvent> { | ||
|
|
||
| public enum FragmentEvent { | ||
| ATTACH, CREATE, CREATE_VIEW, START, RESUME, PAUSE, STOP, DESTROY_VIEW, DESTROY, DETACH |
There was a problem hiding this comment.
The same issue stays here — for fragments it's even harder to well-understand this small FSM mechanism.
There was a problem hiding this comment.
what does FSM mechanism mean? 👀
| unbindNotifier = null; | ||
| } | ||
|
|
||
| private void emitUnBindIfPresent() { |
|
|
||
| companion object { | ||
|
|
||
| private val CORRESPONDING_EVENTS = Function<ActivityEvent, ActivityEvent> { activityEvent -> |
There was a problem hiding this comment.
Can omit Function<ActivityEvent, ActivityEvent> part without decrease in readability
There was a problem hiding this comment.
Talked - can't do this because the compiler won't allow it
|
|
||
| companion object { | ||
|
|
||
| private val CORRESPONDING_EVENTS = Function<FragmentEvent, FragmentEvent> { event -> |
There was a problem hiding this comment.
Talked - can't do this because the compiler won't allow it
|
|
||
| private var unbindNotifier: MaybeSubject<Any>? = null | ||
|
|
||
| private val notifier: MaybeSubject<Any> |
There was a problem hiding this comment.
Oop actually no I just removed this entirely
| override fun onAttachedToWindow() { | ||
| super.onAttachedToWindow() | ||
| if (lifecycleEvents != null) { | ||
| lifecycleEvents!!.onNext(ViewEvent.ATTACH) |
| override fun onDetachedFromWindow() { | ||
| super.onDetachedFromWindow() | ||
| if (lifecycleEvents != null) { | ||
| lifecycleEvents!!.onNext(ViewEvent.DETACH) |
| } | ||
|
|
||
| override fun lifecycle(): Observable<ViewEvent> { | ||
| return lifecycleEvents!!.hide() |
| } | ||
|
|
||
| override fun peekLifecycle(): ViewEvent? { | ||
| return lifecycleEvents!!.value |
This has come up a few times, so I think it's time to have a proper sample rather than just relying on tests to demonstrate usage.
Gist of it is that I added a demo app (doesn't do much but is borrowed heavily from RxLifecycle/Conductor's) + recipes for common cases.